Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add default to_rpc_result function #993

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 23, 2023

add new function to convert Results using the error's Display impl.

@mattsse mattsse requested a review from Rjected as a code owner January 23, 2023 20:41
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jan 23, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse merged commit 865367f into main Jan 23, 2023
@mattsse mattsse deleted the matt/add-to-rpc-resut-fn branch January 23, 2023 21:13
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 5, 2023
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 5, 2023
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants