Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont select more rayon threads than cpus #9956

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: dont select more rayon threads than cpus #9956

merged 1 commit into from
Jul 31, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2024

with 1 available CPU we would configure rayon with 2 threads,
this makes sure that on systems with <=2 cpus, the rayon pool will use 1 cpu

@mattsse mattsse requested review from Rjected and onbjerg as code owners July 31, 2024 19:14
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Jul 31, 2024
Rjected
Rjected approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse enabled auto-merge July 31, 2024 19:23
@mattsse mattsse added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 02d2530 Jul 31, 2024
33 checks passed
@mattsse mattsse deleted the matt/dont-select-more-than-available-cpus branch July 31, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected