chore: move save_blocks to StorageWriter
#9991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-db
joshieDo
requested review from
rakita,
shekhirin,
rkrasiuk,
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
approved these changes
Aug 1, 2024
| @@ -44,6 +51,11 @@ impl<'a, TX, SF> StorageWriter<'a, TX, SF> { | |||
| Self { database, static_file } | |||
| } | |||
|
|
|||
| /// Creates a new instance of [`StorageWriter`] a database provider and a static file instance | |||
| pub const fn from(database: &'a DatabaseProvider<TX>, static_file: SF) -> Self { | |||
| Self::new(Some(database), Some(static_file)) | |||
There was a problem hiding this comment.
do we even need the options if we now have generics for the writer fields?
There was a problem hiding this comment.
probably not, i was already thinking of deleting them in a follow-up
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
StorageWriter::commit&StorageWriter::commit_unwind