Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use borrowed Arena in GethTraceBuilder #178

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Aug 10, 2024

Closes #65

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, some nits and suggestions

Cargo.toml Outdated Show resolved Hide resolved
src/tracing/builder/geth.rs Show resolved Hide resolved
src/tracing/builder/geth.rs Show resolved Hide resolved
src/tracing/builder/geth.rs Outdated Show resolved Hide resolved
@nkysg
Copy link
Contributor Author

nkysg commented Aug 29, 2024

@mattsse @DaniPopes PTAL

@mattsse mattsse merged commit fb94a7c into paradigmxyz:main Aug 30, 2024
11 checks passed
@nkysg nkysg deleted the borrow_arean branch August 30, 2024 07:00
lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this pull request Oct 8, 2024
Closes paradigmxyz#65

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use borrowed Arena in GethTraceBuilder
3 participants