Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use borrowed Arena in GethTraceBuilder #65

Closed
mattsse opened this issue Mar 9, 2024 · 2 comments · Fixed by #178
Closed

Use borrowed Arena in GethTraceBuilder #65

mattsse opened this issue Mar 9, 2024 · 2 comments · Fixed by #178

Comments

@mattsse
Copy link
Contributor

mattsse commented Mar 9, 2024

This should be a cow instead:

https://github.com/paradigmxyz/evm-inspectors/blob/846dec1db14ac42067e7a4bb6a973091cd7eb808/src/tracing/builder/geth.rs#L18-L20

together with:

#63

this would allows us to use an inspector across multiple transact calls, reusing allocated memory
@nkysg nkysg mentioned this issue Aug 10, 2024
Merged
@nkysg
Copy link
Contributor

nkysg commented Aug 10, 2024

May I take this?

mattsse added a commit that referenced this issue Aug 30, 2024
@nkysg @mattsse
Use borrowed Arena in GethTraceBuilder (#178)
fb94a7c 
Closes #65

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@DaniPopes
Copy link
Member

I believe this also applies to the other builders? @mattsse

lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this issue Oct 8, 2024
@nkysg @mattsse @lwedge99
Use borrowed Arena in GethTraceBuilder (paradigmxyz#178)
1d5fffe 
Closes paradigmxyz#65

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use borrowed Arena in GethTraceBuilder nkysg/revm-inspectors
3 participants
@nkysg @mattsse @DaniPopes