Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten alloy-rpc-types dependencies #188

Closed
mattsse opened this issue Aug 30, 2024 · 0 comments · Fixed by #189
Closed

Flatten alloy-rpc-types dependencies #188

mattsse opened this issue Aug 30, 2024 · 0 comments · Fixed by #189
Labels
good first issue Good for newcomers

Comments

@mattsse
Copy link
Contributor

mattsse commented Aug 30, 2024

alloy-rpc-types is a just a crate te reexports other rpc types

this can be replaced by importing the eth and trace crates directly:

https://github.com/paradigmxyz/evm-inspectors/blob/7991b498b3a7960216a36313cab99359db3579c4/Cargo.toml#L35-L35

TODO

  • replace alloy-rpc-types with alloy_rpc_types_eth and alloy_rpc_types_trace
@mattsse mattsse added the good first issue Good for newcomers label Aug 30, 2024
@nkysg nkysg mentioned this issue Aug 30, 2024
Merged
lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this issue Oct 8, 2024
@nkysg @lwedge99
chore: flatten alloy-rpc-types (paradigmxyz#189)
6c408ff 
Closes paradigmxyz#188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: flatten alloy-rpc-types nkysg/revm-inspectors
1 participant
@mattsse