feat(tracing): add unmatched parameter to CallLog
#181
Conversation
This allows for the rendering of unmatched logs as errors in traces
|
@klkvr I just saw your review on foundry-rs/foundry#8506 and still need to add state and logic here for highlighting params. Can we make param highlighting a separate PR in both repos? |
sure! feel free to get the core logic working first though I think we can avoid a separate PR for styling params. They are stored as just |
| @@ -164,12 +175,19 @@ pub struct CallLog { | |||
| pub raw_log: LogData, | |||
| /// Optional complementary decoded log data. | |||
| pub decoded: DecodedCallLog, | |||
| /// A style config that allows for setting styles or error | |||
| /// state externally | |||
| pub style: LogStyle, | |||
There was a problem hiding this comment.
let's move this field to decoded
| /// portable representation of call Log Styling | ||
| #[derive(Debug, Default, PartialEq, Eq, Clone)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub enum LogStyle { |
There was a problem hiding this comment.
this is fine for now, but I think we might want to give more flexibility here by keeping some anstyle type here
we'd need to figure out serde for it, so can be done in a follow up
| @@ -156,6 +156,17 @@ pub struct DecodedCallLog { | |||
| pub params: Option<Vec<(String, String)>>, | |||
| } | |||
|
|
|||
| /// portable representation of call Log Styling | |||
There was a problem hiding this comment.
| /// portable representation of call Log Styling | |
| /// Portable representation of call log styling |
| self.write_branch()?; | ||
|
|
||
| if let Some(name) = &log.decoded.name { | ||
| write!(self.writer, "emit {name}({log_style}")?; | ||
| write!(self.writer, "emit {log_name_style}{name}{log_name_style:#}({log_param_style}")?; |
There was a problem hiding this comment.
hmm, after a second thought we should be able to avoid touching this at all? we can just style log.decoded.name in foundry and get the same effect I think?
There was a problem hiding this comment.
This makes sense. As for the cases where topic 0 or the entire abi-encoded event are styled, those are unreachable because emitting an expected event to watch for supplies the abi, correct?
|
Hi @topocount thanks for you PR, would be great to get this in - do you see an opportunity to implement the feedback? |
@zerosnacks based on responses from @klkvr on foundry-rs/foundry#8506 i think this can be closed but im not completely sure |
This allows for the rendering of unmatched logs as errors in traces
as discussed in foundry-rs/foundry#8506