-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write storage change in trace #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind taking a look at this @klkvr ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebasing on main:
- gate it under a config option for this in
TraceWriterConfig
+ add helper method inTraceWriter
itself - update
fn assert_traces
to accept another bool and follow the implementation ofwrite_bytecodes
in it - update the output files with
SNAPSHOTS=overwrite cargo test
Hi everyone, just checking if there are any updates on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me |
This PR writes the storage change in the trace. Example output when using cast run from the PR: