Fix: track dynamic gas used in opcode tracking gas #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 18, 2024
mattsse
requested changes
Feb 21, 2024
src/opcode.rs
Outdated
| @@ -42,20 +47,67 @@ impl<DB> Inspector<DB> for OpcodeCounterInspector | |||
| where | |||
| DB: Database, | |||
| { | |||
| fn step(&mut self, interp: &mut Interpreter, _context: &mut EvmContext<DB>) { | |||
| fn step(&mut self, interp: &mut Interpreter, context: &mut EvmContext<DB>) { | |||
| self.initialize_interp(interp, context); | |||
There was a problem hiding this comment.
here we need to delegate to gas inspector
src/opcode.rs
Outdated
|
|
||
| *self.opcode_gas.entry(opcode).or_insert(0) += opcode_gas_cost; | ||
| if let Some(opcode) = OpCode::new(opcode_value) { | ||
| let gas_used = self.gas_inspector.last_gas_cost(); |
There was a problem hiding this comment.
this is a bit tricky because gas cost track cost of the entire call so far
we need to track gas at the beginning of the step and on step end we can get the diff by comparing .remaining
see also TracingInspector for reference
There was a problem hiding this comment.
this is a bit tricky because gas cost track cost of the entire call so far
we need to track gas at the beginning of the step and on step end we can get the diff by comparing
.remainingsee also TracingInspector for reference
hey thank you for the review, i'm not sure i understand this
1 task
mattsse
force-pushed
the
Track-dynamic-gas-with-gasinspector
branch
from
a71a3e0
to
2198d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related : #40