chore: fix some TODOs, cleanup #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Apr 27, 2024
| @@ -755,20 +774,19 @@ impl<'a, 'ctx> Builder for EvmLlvmBuilder<'a, 'ctx> { | |||
| self.imul(lhs, rhs) | |||
| } | |||
|
|
|||
| // - [Avoid using arithmetic intrinsics](https://llvm.org/docs/Frontend/PerformanceTips.html) | |||
| // - [Don't use usub.with.overflow intrinsic](https://github.com/rust-lang/rust/pull/103299) | |||
| // - [for unsigned add overflow the recommended pattern is x + y < x](https://github.com/rust-lang/rust/pull/124114#issuecomment-2066173305) | |||
There was a problem hiding this comment.
should improve runtime perf a bit as canonical form is better for optimizations
| @@ -13,8 +13,6 @@ use std::{ | |||
| path::{Path, PathBuf}, | |||
| }; | |||
|
|
|||
| // TODO: Add `nuw`/`nsw` flags to stack length arithmetic. | |||
There was a problem hiding this comment.
no point, llvm figures it out on its own most of the time and it's not worth the effort otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.