Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 Support #157

Closed
arcticlinux opened this issue Dec 1, 2020 · 4 comments
Closed

PHP 8.0 Support #157

arcticlinux opened this issue Dec 1, 2020 · 4 comments

Comments

@arcticlinux
Copy link

I've just been doing some preliminary testing with PHP 8. I didn't test everything but the only thing stopping me from running in PHP 8 with how I'm using Halite was that MB_OVERLOAD_STRING was removed in 8.0.

paragonie/sodium_compat/src/Core/Util.php:915

((int) (ini_get('mbstring.func_overload')) & MB_OVERLOAD_STRING);

I just defined that constant for my rather limited testing.

if (!defined('MB_OVERLOAD_STRING')) {
    define('MB_OVERLOAD_STRING', 2);
}
@paragonie-security
Copy link
Contributor

This is a sodium_compat issue, not a Halite issue, but we'll fix it upstream.

@paragonie-security
Copy link
Contributor

paragonie/sodium_compat@13a6155

@arcticlinux
Copy link
Author

The only other thing was in composer.json, but that has been resolved as well.

@spaze
Copy link

spaze commented Dec 21, 2020

PHP 8 throws a warning when using final private, #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants