Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access modifier final from private methods (PHP 8 support) #158

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

junaidbinfarooq
Copy link
Contributor

@junaidbinfarooq junaidbinfarooq commented Dec 10, 2020

Removes access modifier final from private methods as such methods are never overridden by other classes.

Remove access modifier `final` from private methods as such methods are never overridden by other classes.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 783

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.156%

Totals Coverage Status
Change from base Build 782: 0.0%
Covered Lines: 509
Relevant Lines: 1334

💛 - Coveralls

@spaze
Copy link

spaze commented Dec 21, 2020

Just a heads up that this solves a new PHP 8.0 warning:

Warning: Private methods cannot be final as they are never overridden by other classes

See https://3v4l.org/rl4ti

This was referenced Dec 21, 2020
@junaidbinfarooq
Copy link
Contributor Author

Just a heads up that this solves a new PHP 8.0 warning:

Warning: Private methods cannot be final as they are never overridden by other classes

See https://3v4l.org/rl4ti

Well, that is what I exactly tried to fix. :)

@spaze
Copy link

spaze commented Dec 21, 2020

Well, that is what I exactly tried to fix. :)

Just adding a context so the maintainer can prioritize properly.

@spaze
Copy link

spaze commented Jan 15, 2021

Hey @paragonie-security, can you please merge this and prepare a new release to support PHP 8.0? Thank you! :-)

@junaidbinfarooq
Copy link
Contributor Author

Anyone merging this PR? @paragonie-security?

@junaidbinfarooq junaidbinfarooq changed the title Remove access modifier final from private methods Remove access modifier final from private methods (PHP 8 support) Mar 2, 2021
@spaze
Copy link

spaze commented Apr 3, 2021

@paragonie-scott @paragonie-staff Any chance of merging this soon for flawless PHP 8 support? Thanks!

@paragonie-security paragonie-security merged commit 78e77b6 into paragonie:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants