Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.4 #169

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Support PHP 8.4 #169

merged 9 commits into from
Apr 17, 2024

Conversation

paragonie-security
Copy link
Contributor

Fixes #168

@paragonie-security
Re-enable PHP 8.4 testing
c9fe6f8
@paragonie-security
Remove type declarations
f98291a 
There's no way to make them nullable in PHP 5, so it's our only way forward.

I _could_ add runtime type checks, but why bother?
@paragonie-security
Ensure php72compat is loaded
1a696dd
@paragonie-security
Add type checks at runtime
ef72a25
@paragonie-security
Move PHP 8.4-compat to its own file
249d00b
@paragonie-security paragonie-security marked this pull request as ready for review April 17, 2024 08:19
@paragonie-security paragonie-security merged commit 3fa914e into master Apr 17, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 Compatibility
1 participant
@paragonie-security