explicitly mark argument $alg as nullable #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicitly marking it as nullable is deprecated starting with PHP 8.4.
xabbuh
force-pushed
the
explicit-nullables
branch
from
86c52e1
to
1c92b75
Compare
derrabus
approved these changes
Jul 4, 2024
alexandre-daubois
approved these changes
Jul 8, 2024
|
Could you plan a release for this? Thanks a lot. |
|
Yes, certainly before PHP 8.4 releases. Do you need it sooner? |
It pollutes our CI checks, but we could still apply a patch manually. |
|
Version 2.1.0 has this fix, along with some more nits that we discovered through manual code review (and some micro-optimizations to reduce memory usage). |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly marking it as nullable is deprecated starting with PHP 8.4.