Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added typing for subscribe and unsubscribe events #3014

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Added typing for subscribe and unsubscribe events #3014

merged 3 commits into from
Jan 15, 2021

Conversation

gevzak
Copy link
Contributor

@gevzak gevzak commented Nov 30, 2020

No description provided.

@gevzak gevzak mentioned this pull request Nov 30, 2020
Closed
HackbrettXXX
HackbrettXXX requested changes Dec 3, 2020
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

A couple of things:

  • The name parameter in subscribe should be topic
  • The name parameter in unsubscribe should be called token to clarify it's not the topic
  • Please also add the publish and getTopics methods

@HackbrettXXX HackbrettXXX merged commit edab14a into parallax:master Jan 15, 2021
This was referenced Mar 10, 2021
Closed
Closed
Open
Open
Closed
Open
Open
Open
Open
Closed
Open
Open
Open
Merged
Open
Closed
Closed
Open
Closed
Open
Open
Open
Open
This was referenced Mar 12, 2021
Open
Closed
Open
Closed
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Closed
Open
Closed
Open
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Closed
Closed
Closed
Open
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gevzak @HackbrettXXX