Skip to content

Fix lineHeightFactor as a text option #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix lineHeightFactor as a text option #3282

wants to merge 2 commits into from

Conversation

kdnakt
Copy link

@kdnakt kdnakt commented Oct 2, 2021

Fixes #3234

HackbrettXXX
HackbrettXXX requested changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Could you add a small test case?

@HackbrettXXX
Copy link
Collaborator

Ah, just saw that #3283 fixes the same issue but already has a test case. I'm closing this one in favor of the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lineHeightFactor is ignored if specified as a text option
2 participants
@kdnakt @HackbrettXXX