Added CanDoCrypto operation #129
Conversation
Kakemone
force-pushed
the
CanDoCrypto_patch
branch
3 times, most recently
from
744d4a3 to
cf6dc20
Compare
| @@ -0,0 +1,54 @@ | |||
| # CanDoCrypto | |||
There was a problem hiding this comment.
For the name, we can discuss. In the community meeting it was mentioned "CryptoCanDo" but then I thought if there is a new PSA Crypto operation named psa_crypto_can_do it is going to be PsaCryptoCanDo so might be weird.
There was a problem hiding this comment.
There should probably be some notice of this operation being experimental here as well.
Kakemone
force-pushed
the
CanDoCrypto_patch
branch
3 times, most recently
from
40f803c to
dbe9bb1
Compare
| @@ -0,0 +1,54 @@ | |||
| # CanDoCrypto | |||
There was a problem hiding this comment.
There should probably be some notice of this operation being experimental here as well.
| | Name | Type | Description | | ||
| |--------------|-----------------|-----------------------------| | ||
| | `check_type` | `CheckType` | Type of the check performed | | ||
| | `attributes` | `KeyAttributes` | Value to be checked | |
There was a problem hiding this comment.
Worth adding a link to the place where KeyAttributes is defined
Kakemone
force-pushed
the
CanDoCrypto_patch
branch
from
dbe9bb1 to
4cee382
Compare
| Opcode: 32 (`0x0020`) | ||
|
|
||
| **(EXPERIMENTAL) The parameters for key attestation are in an experimental phase. No guarantees are | ||
| offered around the stability of the interface for any key attestation mechanism.** |
There was a problem hiding this comment.
Oops yeah I forgot to edit it
There was a problem hiding this comment.
How does this sound instead?
**(EXPERIMENTAL) This operation is still being implemented and so no guarantees are offered around the stability of the interface for any key attestation mechanism.**
There was a problem hiding this comment.
Hmm, probably something pointing towards "capability discovery" instead of "key attestation" would be clearer!
Kakemone
force-pushed
the
CanDoCrypto_patch
branch
from
4cee382 to
9a1dfd9
Compare
Added the page for the CanDoCrypto operation and also added the operation to the list of operations and to the table of operations coverage Signed-off-by: Sam Davis <sam.davis@arm.com>
Kakemone
force-pushed
the
CanDoCrypto_patch
branch
from
9a1dfd9 to
687547e
Compare
Added the page for the CanDoCrypto operation and also added the operation to the list of operations and to the table of operations coverage
Signed-off-by: Sam Davis sam.davis@arm.com