Add precisions about versioning #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
reviewed
Feb 25, 2020
src/parsec_client/operations/ping.md
Outdated
|
|
||
| 1. Client requests a Ping operation using the wire protocol version `1.0`. | ||
| 2. Service responds with the highest wire protocol version supported `x.y`. | ||
| 3. Client can now use wire protocol version `x.y` for further requests. |
There was a problem hiding this comment.
Client can now use any wire protocol version below x.y - trying to cover the case where the client might only support a lower version
src/parsec_client/wire_protocol.md
Outdated
| - Header size: a 16-bit unsigned integer whose value is the size of the **remainder** of the header | ||
| in bytes (once the magic number and header size fields have been consumed). Consumers **must** | ||
| use this field to consume the correct number of bytes of header from the input stream, rather | ||
| than use this specification to deduce the header size. | ||
| than use this specification to deduce the header size. This field will remain the same across |
There was a problem hiding this comment.
The last phrase sounds a bit confusing - i.e. sounds a bit like the value will stay the same, but I don't know how to fix that right now.
There was a problem hiding this comment.
Will modify to make it more clear.
Precises the goal of each version in Parsec. See parallaxsecond/parsec#105 for more details. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precises the goal of each version in Parsec. See
parallaxsecond/parsec#105 for more details.
Signed-off-by: Hugues de Valon hugues.devalon@arm.com