Added asymmetric encrypt and decrypt #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR won't pass CI until a new version of |
sbailey-arm
force-pushed
the
add-asym-encrypt-decrypt
branch
from
5c4e8b6 to
50f70ed
Compare
ionut-arm
approved these changes
Jul 7, 2020
src/core/basic_client.rs
Outdated
Comment on lines
555
to
558
| let salt = match salt { | ||
| Some(salt) => Some(Zeroizing::new(salt.to_vec())), | ||
| None=> None, | ||
| }; |
There was a problem hiding this comment.
Now that I think of it, map should be cleaner here.
There was a problem hiding this comment.
Ah yes, that's nice and neat. I realise now that I could have written this as:
let salt = match salt {
Some(salt) => Some(salt.to_vec().into()),
None=> None,
};but I like map. It makes the other match in parsec much clearer!
Version |
sbailey-arm
force-pushed
the
add-asym-encrypt-decrypt
branch
from
50f70ed to
c3ec023
Compare
ionut-arm
reviewed
Jul 7, 2020
sbailey-arm
force-pushed
the
add-asym-encrypt-decrypt
branch
from
c3ec023 to
9ffd3f6
Compare
Signed-off-by: Samuel Bailey <samuel.bailey@arm.com>
sbailey-arm
force-pushed
the
add-asym-encrypt-decrypt
branch
from
9ffd3f6 to
2b6e1d2
Compare
hug-dev
approved these changes
Jul 7, 2020
Comment on lines
+552
to
+553
| plaintext: &[u8], | ||
| salt: Option<&[u8]>, |
There was a problem hiding this comment.
Nice type choice for those vectors!
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Bailey samuel.bailey@arm.com