Remove filesystem checks #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the filesystem checks for correct permissions on Parsec "assets". The checks can now be removed because the new locations in the filesystem mean that only a privileged user can create the files. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
commented
Oct 14, 2020
Comment on lines
-66
to
-84
| if let ClientErrorKind::InvalidServiceResponseType = other { | ||
| true | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
| ClientErrorKind::InvalidProvider => { | ||
| if let ClientErrorKind::InvalidProvider = other { | ||
| true | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
| ClientErrorKind::NoProvider => { | ||
| if let ClientErrorKind::NoProvider = other { | ||
| true | ||
| } else { | ||
| false | ||
| } |
There was a problem hiding this comment.
Clippy started complaining about this in the new version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the filesystem checks for correct permissions on
Parsec "assets". The checks can now be removed because the new locations
in the filesystem mean that only a privileged user can create the files.
Fixes #51