-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate pre-generating Rust protobuf code #98
Labels
Comments
Putting it as "good-first-issue" as I think we can just go with it and pre-generate the contracts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Similarly as the discussion about this topic on the Go client PR, we should investigate if it's good and worth it to pre-generate the code from our protobuf files and check it in tree instead of generating it for everybuild.
Since our contracts are stable and backward-compatible by design, the main advantage of this is winning compilation time by requiring less build step and less dependencies. Seeing the number of times those files are generated, I am sure we could see a huge advantage.
The protobuf code could be generated under a feature disabled by default (by default use the pre-generated one) and the CI could check that the generated code is the one we expect.
The text was updated successfully, but these errors were encountered: