Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit the generated Rust protobuf files in tree #117

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Jul 23, 2021

That will speed-up the build process.

Fix #98

By default, 66 dependencies, 25.25 seconds.
With the feature (as it was before), 92 dependencies, 28.67 seconds.

edit: also removes the dependency on protoc for some targets (see https://parallaxsecond.github.io/parsec-book/parsec_service/build_run.html#dependencies)

That will speed-up the build process.

Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
@hug-dev hug-dev requested a review from ionut-arm July 23, 2021 16:32
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hug-dev hug-dev merged commit b661fe0 into parallaxsecond:main Jul 26, 2021
@hug-dev hug-dev deleted the protobuf-generated branch July 26, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate pre-generating Rust protobuf code
2 participants