update to prost 0.12 #154
Open
update to prost 0.12 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derived Enumerations now provide their own conversion implementation from i32, so map any DecodeErrors originating from there to InvalidEncoding, and drop the manual impls that existed before. Closes: parallaxsecond#153 Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
note that I have no deeper knowledge of parsec or prost, but this is currently blocking some upgrades in Debian, so I lent a hand ;) |
|
the build check fails because of unnecessary qualifications, see #151 (although that might bump MSRV too aggressively for your taste ;)) the MSRV check fails because the new prost requires a newer rustc - not sure what your policies are, so I'll leave that up to you! |
gowthamsk-arm
requested review from
ionut-arm,
tgonzalezorlandoarm and
gowthamsk-arm
|
Thanks for the changes. The PR looks good, just waiting for #151 to be resolved so that the CI tests can be completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
derived Enumerations now provide their own conversion implementation from i32, so map any DecodeErrors originating from there to InvalidEncoding, and drop the manual impls that existed before.
Closes: #153