Add faillible methods #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies and adds methods to KeyAttributes: * if the method name is a declaration, the method will return a Result and log the error, so that it avoid duplication in the caller's code * if the method name is an interrogation, the method will return a bool and not log anything Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
ionut-arm
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies and adds methods to KeyAttributes:
and log the error, so that it avoid duplication in the caller's code
and not log anything
Signed-off-by: Hugues de Valon hugues.devalon@arm.com