Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to check opcode nature #88

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Oct 14, 2020

Signed-off-by: Hugues de Valon hugues.devalon@arm.com

Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change, I'm guessing splitting Opcode into CoreOperation(CoreOperation) and CryptoOperation(CryptoOperation) is too much trouble?

@hug-dev
Copy link
Member Author

hug-dev commented Oct 14, 2020

I'm guessing splitting Opcode into CoreOperation(CoreOperation) and CryptoOperation(CryptoOperation) is too much trouble

Yes probably for the scope of what I want to do in Parsec. But I agree that this is a better solution to use type for that, in the future. Similarly with everything else: Provide trait, ResponseStatus, etc...

@hug-dev hug-dev merged commit 4986c0d into parallaxsecond:master Oct 14, 2020
@hug-dev hug-dev deleted the opcode-nature branch October 14, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants