Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: Temporary patch rcgen crate for RSA-PSS CSR support #128

Conversation

tgonzalezorlandoarm
Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm commented May 7, 2024

RSA-PSS CSR creation functionality has been recently added.

For creating the CSRs, we are currently using rcgen.

For RSA-PSS, rcgen defined the PKCS_RSA_PSS_SHA256 type, which should be used instead of the currently used one (PKCS_RSA_SHA256).

Unfortunately, rcgen does not expose this type as there have been some issues validating the CSR creation of this type.

This has been tested using real RSA PSS keys and the functionality works as expected.

  • Patch rcgen to expose the PKCS_RSA_PSS_SHA256 type. The patch applies until these changes get fixed/merged upstream
    in rcgen.
  • Use this type in parsec-tool CSR creation for RSA-PSS.

RSA-PSS CSR creation functionality has been recently added.

For creating the CSRs, we are currently using rcgen.

For RSA-PSS, rcgen defined the PKCS_RSA_PSS_SHA256 type, which
should be used instead of the currently used one (PKCS_RSA_SHA256).

Unfortunately, rcgen does not expose this type as there have been
some issues validating the CSR creation of this type.

This has been tested using real RSA PSS keys and the functionality
works as expected.

 * Patch rcgen to expose the PKCS_RSA_PSS_SHA256 type.
   The patch applies until these changes get fixed/merged upstream
   in rcgen.
 * Use this type in parsec-tool CSR creation for RSA-PSS.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 0431445 into parallaxsecond:main May 14, 2024
5 checks passed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/support-pss-csr branch May 14, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants