Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the spiffe related features in its own branch #327

Closed
hug-dev opened this issue Jan 27, 2021 · 0 comments
Closed

Move the spiffe related features in its own branch #327

hug-dev opened this issue Jan 27, 2021 · 0 comments
Assignees
@hug-dev
Labels
bug Something isn't working code health Issues concerning overall code quality, safety and best practice

Comments

@hug-dev
Copy link
Member

hug-dev commented Jan 27, 2021

Because the spiffe dependency used for the JWT SVID authenticator is for now just a git dependency, that prevents publishing the parsec service crate on crates.io. Similarly for all crates using spiffe: parsec-client, parsec-tool, etc...
For now the most sane option is to push this feature in its own spiffe branch on the various repos so that the master branch can still be published. As soon as the needed crates are published we can modify the branch and merge it back to master.
This should change nothing for people already using a git dependency on the Parsec clients or Parsec from GitHub directly.

The main drawback is that if it lasts a long time, we might have to rebase the spiffe branch on master to keep it up-to-date with developments.

I plan to do it the following way:

  1. Make a PR on master to remove all the spiffe stuff
  2. Make a PR on spiffe to revert there the commit from 1.
@hug-dev hug-dev added bug Something isn't working code health Issues concerning overall code quality, safety and best practice labels Jan 27, 2021
@hug-dev hug-dev self-assigned this Jan 27, 2021
hug-dev added a commit to hug-dev/parsec-client-rust that referenced this issue Jan 27, 2021
@hug-dev
Remove spiffe-based feature from master
5e8702f 
This will be pushed in its own branch, see
parallaxsecond/parsec#327

Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
This was referenced Jan 27, 2021
Merged
Merged
Merged
@hug-dev hug-dev closed this as completed Jan 27, 2021
@hug-dev hug-dev mentioned this issue Feb 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hug-dev hug-dev

Labels
bug Something isn't working code health Issues concerning overall code quality, safety and best practice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hug-dev