Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Fixed Common header tests #351

Closed
hug-dev opened this issue Mar 2, 2021 · 2 comments
Closed

Add more Fixed Common header tests #351

hug-dev opened this issue Mar 2, 2021 · 2 comments
Labels
code health Issues concerning overall code quality, safety and best practice good first issue Good for newcomers medium Effort label testing Task related to testing

Comments

@hug-dev
Copy link
Member

hug-dev commented Mar 2, 2021

The book describes some conditions for the valid values of some fields, on this page.

We should add some sanity checks in this file making sure that:

  • an error is returned if fields have illegal values for requests
  • response fields are always correct
@hug-dev hug-dev added code health Issues concerning overall code quality, safety and best practice medium Effort label testing Task related to testing labels Mar 2, 2021
@hug-dev hug-dev added the good first issue Good for newcomers label Mar 2, 2021
@ionut-arm
Copy link
Member

I'm ok with adding more E2E tests for this, but they should not be the primary way we verify this alignment (mostly because we're not directly testing the code responsible for handling those cases here).

The interface code that handles conversion to/from wire protocol is here - we need to have tests for all the conditions in read_from_stream.

@hug-dev
Copy link
Member Author

hug-dev commented Jul 23, 2021

Done in #440

@hug-dev hug-dev closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Issues concerning overall code quality, safety and best practice good first issue Good for newcomers medium Effort label testing Task related to testing
Projects
None yet
Development

No branches or pull requests

2 participants