Add various tests checking contracts #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
force-pushed
the
add-contract-tests
branch
3 times, most recently
from
5a45f25
to
96c6f08
Compare
Also adds checks in the providers to prevent generating a public asymmetric key. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
hug-dev
force-pushed
the
add-contract-tests
branch
from
96c6f08
to
1dcb8fa
Compare
ionut-arm
approved these changes
Jun 2, 2021
|
|
||
| #[cfg(not(any(feature = "pkcs11-provider", feature = "tpm-provider")))] | ||
| #[test] | ||
| fn import_and_export_ecc_public_key() -> Result<()> { |
There was a problem hiding this comment.
Feel free to ignore this since it isn't in the remit of this PR, but it would be nicer if these tests panicked instead of returning a Result.
There was a problem hiding this comment.
Yes agree, there are other tests where it's like that. It would be nice to make one PR that changes everything. Added #444 for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #389
The rest of the contracts are mostly already covered.