Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ingress/egress trace logs #416

Closed
hug-dev opened this issue May 7, 2021 · 0 comments · Fixed by #465
Closed

Fix ingress/egress trace logs #416

hug-dev opened this issue May 7, 2021 · 0 comments · Fixed by #465
Assignees
@MattDavis00
Labels
bug Something isn't working good first issue Good for newcomers small Effort label

Comments

@hug-dev
Copy link
Member

hug-dev commented May 7, 2021

I think we should use the convention:

  • have an ingress log in the first line of a function
  • have an egress log on the line just after the function was called

Moreover, this is wrong (export_public_key instead of export_key).

I noticed as some in/egress logs are missing.
@hug-dev hug-dev added bug Something isn't working good first issue Good for newcomers labels May 7, 2021
@ionut-arm ionut-arm added the small Effort label label Jul 6, 2021
@MattDavis00 MattDavis00 self-assigned this Jul 8, 2021
MattDavis00 added a commit to MattDavis00/parsec that referenced this issue Jul 8, 2021
@MattDavis00
Added missing ingress logs to providers. parallaxsecond#416
0d57084 
Added to core, mbed_crypto, pkcs11, tpm, and trusted_service providers.
Fixed psa_export_key function being referenced as psa_export_public_key.
Changed some egress logs from `psa_aead_encrypt_egress` format to
`psa_aead_encrypt egress` format.

Issue parallaxsecond#416

Signed-off-by: Matt Davis <matt.davis@arm.com>
@MattDavis00 MattDavis00 mentioned this issue Jul 8, 2021
Merged
hug-dev added a commit that referenced this issue Jul 8, 2021
@hug-dev
Merge pull request #465 from MattDavis00/feature-ingress-egress-logs
6018d25 
Added missing ingress logs to providers. #416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattDavis00 MattDavis00

Labels
bug Something isn't working good first issue Good for newcomers small Effort label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing ingress logs to providers. #416 MattDavis00/parsec
3 participants
@MattDavis00 @hug-dev @ionut-arm