Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS provider #284

Merged

Conversation

ionut-arm
Copy link
Member

Create base of Trusted Service provider - it connects to the service
and can be instantiated in the service.

Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com

@ionut-arm ionut-arm added enhancement New feature or request firmware framework Issues related to compatibility with Arm FF-A labels Nov 10, 2020
@ionut-arm ionut-arm self-assigned this Nov 10, 2020
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏊 A few comments

Cargo.toml Outdated Show resolved Hide resolved
src/providers/trusted_service/mod.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/mod.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/mod.rs Show resolved Hide resolved
src/providers/trusted_service/context.rs Show resolved Hide resolved
src/providers/trusted_service/context.rs Outdated Show resolved Hide resolved
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's continue with it 🧑‍🔧

Comment on lines +99 to +100
unsafe impl Sync for Context {}
unsafe impl Send for Context {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, hide them at the end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Create base of Trusted Service provider - it connects to the service
and can be instantiated in the service.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm ionut-arm merged commit 8f489e0 into parallaxsecond:trusted-service-provider Nov 16, 2020
@ionut-arm ionut-arm deleted the ts-context branch November 16, 2020 14:29
@ionut-arm ionut-arm mentioned this pull request Jan 4, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request firmware framework Issues related to compatibility with Arm FF-A
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants