Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate and destroy key to TS provider #285

Merged

Conversation

ionut-arm
Copy link
Member

This commit adds functionality for generating and destroying
keys in the Trusted Service provider.

Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com

@ionut-arm ionut-arm added enhancement New feature or request firmware framework Issues related to compatibility with Arm FF-A labels Nov 16, 2020
@ionut-arm ionut-arm self-assigned this Nov 16, 2020
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I don't fully understand how the context work, I've asked some initial questions

src/providers/trusted_service/mod.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/mod.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/key_management.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/key_management.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/key_management.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/key_management.rs Outdated Show resolved Hide resolved
@ionut-arm
Copy link
Member Author

Fixed all the comments, and just to note - I did try this locally and the create_and_destroy test passed 👌

Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adressing the comments!

This commit adds functionality for generating and destroying
keys in the Trusted Service provider.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm ionut-arm merged commit eadc312 into parallaxsecond:trusted-service-provider Nov 17, 2020
@ionut-arm ionut-arm deleted the ts-gen-destroy branch November 17, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request firmware framework Issues related to compatibility with Arm FF-A
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants