Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asymmetric sign and verify to TS provider #286

Merged

Conversation

ionut-arm
Copy link
Member

This commit adds functionality to the Trusted Service provider
allowing it to sign and verify hashes.

Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com

@ionut-arm ionut-arm added the firmware framework Issues related to compatibility with Arm FF-A label Nov 18, 2020
@ionut-arm ionut-arm self-assigned this Nov 18, 2020
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! A few comments

src/providers/trusted_service/asym_sign.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/mod.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/mod.rs Outdated Show resolved Hide resolved
src/providers/trusted_service/context/asym_sign.rs Outdated Show resolved Hide resolved
This commit adds functionality to the Trusted Service provider
allowing it to sign and verify hashes.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm
Copy link
Member Author

Fixed according to all points raised. I also rebased on top of the latest TS version, so there are some changes to the build and Context connection

Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this code

src/providers/trusted_service/context/mod.rs Show resolved Hide resolved
@ionut-arm ionut-arm merged commit c17f874 into parallaxsecond:trusted-service-provider Nov 19, 2020
@ionut-arm ionut-arm deleted the ts-sign-verify branch November 19, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firmware framework Issues related to compatibility with Arm FF-A
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants