-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryptoAuthentication Library provider - support for PsaSignHash and PsaVerifyHash operations. #413
CryptoAuthentication Library provider - support for PsaSignHash and PsaVerifyHash operations. #413
Conversation
…saVerifyHash operations. Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! I've left a few comments below
…saVerifyHash operations. Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
…skiGL/parsec into calib-psa-sign-verify-hash Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
dd3ea1d
to
4a7c783
Compare
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
This commit adds cross-compilation for the TPM provider and moves all the cross-compilation into a dedicated Docker container. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
4a7c783
to
98fd88a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the changes, though it would've been preferable to rebase on main
instead of merging it in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for this and the effort for the end-to-end tests 👌 Just one typo in the log
op.validate(key_attributes)?; | ||
|
||
let key_id = self.key_info_store.get_key_id::<u8>(&key_triple)?; | ||
info!("psa_sign_hash_internal - using slot {}", key_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should maybe be psa_verify_hash_internal
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I am correcting this.
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
Signed-off-by: Robert Drazkowski Robert.Drazkowski@globallogic.com