Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoAuthentication Library provider - support for PsaSignHash and PsaVerifyHash operations. #413

Merged

Conversation

RobertDrazkowskiGL
Copy link
Contributor

Signed-off-by: Robert Drazkowski Robert.Drazkowski@globallogic.com

…saVerifyHash operations.

Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
@hug-dev hug-dev added the platforms Compatibility with different secure services or hardware platforms label May 5, 2021
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I've left a few comments below

src/providers/cryptoauthlib/asym_sign.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/asym_sign.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/asym_sign.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/asym_sign.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/key_management.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/key_slot.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/key_slot.rs Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/key_slot.rs Outdated Show resolved Hide resolved
…saVerifyHash operations.

Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
…skiGL/parsec into calib-psa-sign-verify-hash

Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
RobertDrazkowskiGL and others added 4 commits May 10, 2021 22:15
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
This commit adds cross-compilation for the TPM provider and moves all
the cross-compilation into a dedicated Docker container.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the changes, though it would've been preferable to rebase on main instead of merging it in

@ionut-arm ionut-arm requested a review from hug-dev May 11, 2021 10:41
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for this and the effort for the end-to-end tests 👌 Just one typo in the log

op.validate(key_attributes)?;

let key_id = self.key_info_store.get_key_id::<u8>(&key_triple)?;
info!("psa_sign_hash_internal - using slot {}", key_id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maybe be psa_verify_hash_internal here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I am correcting this.

Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
@hug-dev hug-dev merged commit 427f447 into parallaxsecond:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platforms Compatibility with different secure services or hardware platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants