Isolate config logic and add e2e config tests #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit puts the serialised version of the config file into one single Rust file. This file is put under a CODEOWNERS rule so that it is carefully check for breaking changes. It also adds one end-to-end config test checking the behaviour of various fields. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
ionut-arm
approved these changes
May 19, 2021
| auth_type = "Direct" | ||
|
|
||
| [[key_manager]] | ||
| name = "I-want-to-speak-to-the-manager" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit puts the serialised version of the config file into one
single Rust file. This file is put under a CODEOWNERS rule so that it is
carefully check for breaking changes.
It also adds one end-to-end config test checking the behaviour of
various fields.
See #393 for details