Fix code coverage reports #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes our code coverage reports for Parsec. The issue was found to be the use of the `--release` flag for running the tarpaulin-instrumented service binary. This flag seems to make `tarpaulin` lose track of code-to-instruction mapping and thus lose a lot of code coverage data, maybe due to aliasing. The `--release` flag was removed and the `ci.sh` script modified to ensure builds continue to work. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
hug-dev
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes our code coverage reports for Parsec. The issue was
found to be the use of the
--releaseflag for running thetarpaulin-instrumented service binary. This flag seems to make
tarpaulinlose track of code-to-instruction mapping and thus lose alot of code coverage data, maybe due to aliasing.
The
--releaseflag was removed and theci.shscript modified toensure builds continue to work.
Fixes #460