Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CanDoCrypto trait and use it for PKCS11 and TPM providers #550

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Implement CanDoCrypto trait and use it for PKCS11 and TPM providers #550

merged 3 commits into from
Oct 27, 2021

Conversation

anta5010
Copy link
Collaborator

Signed-off-by: Anton Antonov Anton.Antonov@arm.com

@anta5010 anta5010 requested review from hug-dev and ionut-arm October 25, 2021 08:57
@anta5010 anta5010 force-pushed the candocrypto-trait branch 5 times, most recently from 370c83a to 07b89e0 Compare October 26, 2021 12:04
@anta5010
Implement CanDoCrypto trait and use it for PKCS11 and TPM providers
b025998 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
@anta5010
Re-factor existing can-do-crypto e2e tests
33e97eb 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
ionut-arm
ionut-arm reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few comments. Are you going to leave the TPM issue open until we get the hardware capability testing in place as well?

src/providers/crypto_capability.rs Outdated Show resolved Hide resolved
e2e_tests/tests/per_provider/normal_tests/capability_discovery.rs Show resolved Hide resolved
src/providers/tpm/capability_discovery.rs Outdated Show resolved Hide resolved
src/providers/crypto_capability.rs Show resolved Hide resolved
src/providers/tpm/capability_discovery.rs Show resolved Hide resolved
@anta5010
Fix can_do_crypto_internal for TPM provider and add e2e tests for it.
f0a9991 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
@anta5010 anta5010 requested a review from ionut-arm October 27, 2021 10:05
ionut-arm
ionut-arm approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 thanks!

@anta5010 anta5010 merged commit 068c72c into parallaxsecond:can-do-crypto Oct 27, 2021
@ionut-arm ionut-arm mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@hug-dev hug-dev Awaiting requested review from hug-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anta5010 @ionut-arm