Add ActivateCredential tests and fixes #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
changed the title
ionut-arm
force-pushed
the
activ-cred-tests
branch
from
bfd883a to
25aaa29
Compare
A number of new tests are added for the new ActivateCredential key attestation mechanism. A couple of fixes were also implemented, based on issues discovered during testing: * the TPM provider now acknowledges that it supports key attestation * PrepareKeyAttestation now returns buffers under the correct name Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
force-pushed
the
activ-cred-tests
branch
from
25aaa29 to
9cf464e
Compare
anta5010
approved these changes
Nov 25, 2021
Tests that open a `Context` are made serial to ensure no two of them open Contexts in parallel which might cause issues. The Activate Credential tests are also moved into a separate module. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of new tests are added for the new ActivateCredential key
attestation mechanism.
A couple of fixes were also implemented, based on issues discovered
during testing:
Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com