Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generate random support into TPM provider #595

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Add generate random support into TPM provider #595

merged 5 commits into from
Apr 13, 2022

Conversation

anta5010
Copy link
Collaborator

Implements #593

Signed-off-by: Anton Antonov Anton.Antonov@arm.com

@anta5010
Add generate randmon support into TPM provider
67e04b1 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
@anta5010
Add generate randmon support into TPM provider
8073467 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
@anta5010 anta5010 changed the title Add generate randmon support into TPM provider Add generate random support into TPM provider Mar 25, 2022
ionut-arm
ionut-arm reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only got one request

src/providers/tpm/generate_random.rs Outdated Show resolved Hide resolved
@anta5010
Raise an error instead of panicking
7d2fc65 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
ionut-arm
ionut-arm approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 ready to merge once the code freeze ends

@anta5010
Fix list_opcodes test
7b2dc18 
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
@ionut-arm
Copy link
Member

cc @GowthamSureshKumar @MohamedAsaker

@ionut-arm ionut-arm merged commit 5f4c222 into parallaxsecond:main Apr 13, 2022
@ionut-arm ionut-arm mentioned this pull request Apr 26, 2022
Closed
@anta5010 anta5010 mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@Kakemone Kakemone Kakemone approved these changes

@hug-dev hug-dev Awaiting requested review from hug-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anta5010 @ionut-arm @Kakemone