Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem reported by Clippy (rust 1.62) #624

Merged

Conversation

mohamedasaker-arm
Copy link
Contributor

Signed-off-by: Mohamed Omar Asaker mohamed.omarasaker@arm.com

@anta5010
Copy link
Collaborator

Is this change compatible with old version of rust. Like 1.58.1 we use in Yocto?

@ionut-arm
Copy link
Member

Is this change compatible with old version of rust. Like 1.58.1 we use in Yocto?

We do have CI checks for that sort of thing, so it should be caught if there's a regression.

@mohamedasaker-arm
Copy link
Contributor Author

Hi @anta5010 good point!
I've just used 1.58.1 and run the following commands as test
cargo clippy --all-targets --features=all-providers -- -D clippy::all -D clippy::cargo
cargo clippy --all-targets --features=pkcs11-provider --manifest-path e2e_tests/Cargo.toml -- -D clippy::all -D clippy::cargo
and I see no complaints on these changes. Do you have another check in mind?

@ionut-arm
Copy link
Member

Just to confirm: the CI checks for 1.57 as MSRV, so anything past that should work fine.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
@mohamedasaker-arm mohamedasaker-arm marked this pull request as ready for review July 13, 2022 10:24
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ionut-arm ionut-arm merged commit 60808d8 into parallaxsecond:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants