-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing/568 add key persistence tests for ts provider #625
Merged
ionut-arm
merged 11 commits into
parallaxsecond:main
from
mohamedasaker-arm:testing/568-add-key-persistence-tests-for-TS-provider
Aug 9, 2022
Merged
Testing/568 add key persistence tests for ts provider #625
ionut-arm
merged 11 commits into
parallaxsecond:main
from
mohamedasaker-arm:testing/568-add-key-persistence-tests-for-TS-provider
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
reviewed
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the change, looks pretty good, just a few minor comments
638da28
to
3c33722
Compare
ionut-arm
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
3c33722
to
e1239b2
Compare
e1239b2
to
21c86c4
Compare
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
- Move keys and mapping files into a separate folders to avoid conflict between TS mock and other providers - Add comments - Re-organize script Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
The old version of parsec is compatible with an old version of TS before extending the RPC parameters: https://git.trustedfirmware.org/TS/trusted-services.git/commit/?h=integration&id=c3f4e9a7550ee4fddf2d24127ef33ca514351806 Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
The reason is the old version of TS is only used in the generate_keys script. It avoids confusion between different TS versions in the Dockerfile. Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
side: Update a comment in ci script Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
21c86c4
to
f713362
Compare
ionut-arm
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.