Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing/568 add key persistence tests for ts provider #625

Conversation

mohamedasaker-arm
Copy link
Contributor

No description provided.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the change, looks pretty good, just a few minor comments

e2e_tests/docker_image/parsec-service-test-all.Dockerfile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
e2e_tests/tests/per_provider/key_mappings.rs Show resolved Hide resolved
@mohamedasaker-arm mohamedasaker-arm marked this pull request as ready for review August 3, 2022 14:26
@mohamedasaker-arm mohamedasaker-arm requested a review from a team as a code owner August 3, 2022 14:26
@mohamedasaker-arm mohamedasaker-arm force-pushed the testing/568-add-key-persistence-tests-for-TS-provider branch from 638da28 to 3c33722 Compare August 3, 2022 14:27
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@mohamedasaker-arm mohamedasaker-arm force-pushed the testing/568-add-key-persistence-tests-for-TS-provider branch from 3c33722 to e1239b2 Compare August 3, 2022 15:08
@mohamedasaker-arm mohamedasaker-arm force-pushed the testing/568-add-key-persistence-tests-for-TS-provider branch from e1239b2 to 21c86c4 Compare August 8, 2022 18:45
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
- Move keys and mapping files into a separate folders to avoid conflict
  between TS mock and other providers
- Add comments
- Re-organize script

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
The old version of parsec is compatible with an old version of TS
before extending the RPC parameters:
https://git.trustedfirmware.org/TS/trusted-services.git/commit/?h=integration&id=c3f4e9a7550ee4fddf2d24127ef33ca514351806

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
The reason is the old version of TS is only used in the generate_keys script.
It avoids confusion between different TS versions in the Dockerfile.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
side: Update a comment in ci script

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
@mohamedasaker-arm mohamedasaker-arm force-pushed the testing/568-add-key-persistence-tests-for-TS-provider branch from 21c86c4 to f713362 Compare August 8, 2022 19:22
@ionut-arm ionut-arm merged commit 38b9ab0 into parallaxsecond:main Aug 9, 2022
@mohamedasaker-arm mohamedasaker-arm linked an issue Sep 2, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add key persistence tests for TS provider
2 participants