build and share docker image across jobs #628
Merged
+131
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
reviewed
Aug 22, 2022
ionut-arm
reviewed
Aug 30, 2022
|
Are we leaving this until after the 1.1.0 release? |
mohamedasaker-arm
force-pushed
the
ci/build-share-docker-image-across-jobs
branch
from
d9436dd to
abe0949
Compare
|
@ionut-arm We can merge if it's in good shape (I think it is). Anyhow It's not a part of the service itself. |
mohamedasaker-arm
force-pushed
the
ci/build-share-docker-image-across-jobs
branch
from
0843d9d to
32c2b3d
Compare
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
mohamedasaker-arm
force-pushed
the
ci/build-share-docker-image-across-jobs
branch
from
32c2b3d to
8270d3d
Compare
|
LGTM |
gowthamsk-arm
approved these changes
Sep 6, 2022
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motive for this change is:
Whenever the docker image needs to be updated, test these changes on the CI
Then we enable building the docker image and run it for each job, as jobs in the workflow don't share the local docker registry.
This change is to build the docker and export it to be used across the workflow jobs.