Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/119 implement configurable exclusion of deprecated primitives #633

Conversation

mohamedasaker-arm
Copy link
Contributor

This change introduces configuration to reject the deprecated primitives.

Fixes #119

- Add Configuration tests
- Add Configuration parameter allow_deprecated to GlobalConfig
- Add Check deprecated in generate/import operation for each provider

Note: A warning will be issued in the import operation even service
is configured to reject the deprecated primitives

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
…cated key

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
@mohamedasaker-arm mohamedasaker-arm marked this pull request as ready for review September 3, 2022 11:20
@mohamedasaker-arm mohamedasaker-arm requested a review from a team as a code owner September 3, 2022 11:20
@mohamedasaker-arm mohamedasaker-arm marked this pull request as draft September 5, 2022 08:17
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
@mohamedasaker-arm mohamedasaker-arm force-pushed the feature/119-Implement-configurable-exclusion-of-deprecated-primitives branch from 4eca69d to 9b0006b Compare September 5, 2022 08:24
@mohamedasaker-arm mohamedasaker-arm marked this pull request as ready for review September 5, 2022 09:14
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the patch! Left some comments, let me know what you think.

config.toml Outdated Show resolved Hide resolved
src/providers/cryptoauthlib/key_management.rs Outdated Show resolved Hide resolved
Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
@ionut-arm ionut-arm merged commit 29c5df1 into parallaxsecond:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement configurable exclusion of deprecated primitives
3 participants