Modify tests directory structure #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
force-pushed
the
new-test-structure
branch
from
b1a97b8
to
1e6c9ea
Compare
ionut-arm
reviewed
Dec 24, 2019
|
|
||
| ##################### | ||
| # Integration tests # | ||
| ##################### | ||
| RUST_BACKTRACE=1 RUST_LOG=info cargo run & | ||
| RUST_BACKTRACE=1 cargo run $FEATURES \ |
There was a problem hiding this comment.
Is there no need to sleep after this?
There was a problem hiding this comment.
No, because we do a cargo build before so that is alsmost instantaneous 😸
tests/cross_compilation/config.toml
Outdated
| listener_type = "DomainSocket" | ||
| timeout = 200 # in milliseconds | ||
|
|
||
| # No providers are compiled in for the cross-compilation example. |
There was a problem hiding this comment.
Not sure this is the case - the providers are compiled, this config file is just for actually running the service, right?
There was a problem hiding this comment.
Well as of now, the cross-compilation test only compiles the service for Aarch64 and does not even execute any test, so this file is useless. I will remove it.
| RUN apt-get update && \ | ||
| apt-get install -y wget automake autoconf libtool pkg-config && \ | ||
| apt-get install -y curl libssl-dev | ||
| # These libraries are needed for bindgen as it uses libclang.so |
| # It is meant to be executed inside one of the container which Dockerfiles | ||
| # are in tests/per_provider/provider_cfg/*/. | ||
| # | ||
| # Usage: ./tests/per_provider/ci.sh PROVIDER_NAME |
There was a problem hiding this comment.
Might be worth adding a check at the beginning of scripts that require an argument and print something like this if that argument wasn't provided
In order to execute the tests under different single providers, under all providers and for cross-compilation, split the tests directory into sub-directories. Each one contains a specific configuration file to run the tests under. Please check issue parallaxsecond#69 for details. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
hug-dev
force-pushed
the
new-test-structure
branch
from
1e6c9ea
to
8212cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to execute the tests under different single providers, under
all providers and for cross-compilation, split the tests directory into
sub-directories. Each one contains a specific configuration file to run
the tests under.
Please check issue #69 for details.
Signed-off-by: Hugues de Valon hugues.devalon@arm.com