Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zeroize version #107

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

gowthamsk-arm
Copy link
Contributor

Updated to 1.4.3 not 1.5.* as the rsa crate has dependencies issue

Relates to #602

Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com

Updated to 1.4.3 not 1.5.* as the rsa crate has dependencies issue

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to compile it with the Parsec service MSRV?

@gowthamsk-arm
Copy link
Contributor Author

I've compiled this crate with v1.53.0 using cargo +1.53.0 build command and it builds successfully. Can you please tell me if there is there any other check I need to do?

@ionut-arm
Copy link
Member

Can you please tell me if there is there any other check I need to do?

No, my question was only related to that comment in the Cargo.toml file that you removed, wanted to make sure that was tested and we don't have to worry about it anymore!

@ionut-arm ionut-arm merged commit 22ebb4d into parallaxsecond:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants