Added tests for all operations that were added that are supported by Mbed Crypto #50
Conversation
sbailey-arm
force-pushed
the
add-all-missing-operations
branch
from
c374842 to
21ca95a
Compare
| fn key_agreement() { | ||
| let alg = RawKeyAgreement::Ecdh; | ||
| let attributes = Attributes { | ||
| key_type: Type::EccKeyPair { |
There was a problem hiding this comment.
So key agreement can also be done on ECC keys? Maybe we need to update this code then.
Is it the case that Ecdh can be used with ECC keys where Ffdh can be used with DH keys?
There was a problem hiding this comment.
Yes, ECC supports key agreement. Not sure about second question, maybe @ionut-arm has an idea? It also doesn't look like Mbed Crypto supports FFDH at the moment.
There was a problem hiding this comment.
Yes and yes. I actually asked a similar question back in the day and I think they've included clarification on this in subsequent releases of the spec - found it weird that they didn't explicitly specify that ECC keys are used for ECDH when they have a DH key type.
The "classical" Diffie-Hellman (over finite fields) uses DH keys and is represented by FFDH, the elliptic-curve variant uses ECC keys and is represented by ECDH.
There was a problem hiding this comment.
Yeah, that code seems wrong, good spot!
There was a problem hiding this comment.
Cool, thanks for the clarification! In that case, could you update it as part of this PR @sbailey-arm please 😃 ?
sbailey-arm
force-pushed
the
add-all-missing-operations
branch
from
21ca95a to
b63ffba
Compare
psa-crypto/src/types/key.rs
Outdated
| .. | ||
| }) => true, | ||
| Algorithm::AsymmetricSignature(sign_alg) => sign_alg.is_ecc_alg(), | ||
| Algorithm::AsymmetricEncryption(_) => true, |
There was a problem hiding this comment.
Hmm I think I told you something wrong, there don't seem to be any asymmetric encryption algorithms for ECC keys.
sbailey-arm
force-pushed
the
add-all-missing-operations
branch
from
b63ffba to
730a3d7
Compare
| Type::EccKeyPair { .. } | Type::EccPublicKey { .. } => match alg { | ||
| Algorithm::KeyAgreement(KeyAgreement::Raw(RawKeyAgreement::Ecdh)) | ||
| | Algorithm::KeyAgreement(KeyAgreement::WithKeyDerivation { | ||
| ka_alg: RawKeyAgreement::Ecdh, | ||
| .. | ||
| }) => true, | ||
| Algorithm::AsymmetricSignature(sign_alg) => sign_alg.is_ecc_alg(), | ||
| _ => false, | ||
| }, | ||
| Type::DhKeyPair { .. } | Type::DhPublicKey { .. } => { | ||
| if let Algorithm::KeyAgreement(_) = alg { | ||
| if let Algorithm::KeyAgreement(KeyAgreement::Raw(RawKeyAgreement::Ffdh)) | ||
| | Algorithm::KeyAgreement(KeyAgreement::WithKeyDerivation { | ||
| ka_alg: RawKeyAgreement::Ffdh, | ||
| .. | ||
| }) = alg | ||
| { |
…Mbed Crypto Signed-off-by: Samuel Bailey <samuel.bailey@arm.com>
sbailey-arm
force-pushed
the
add-all-missing-operations
branch
from
730a3d7 to
7444a77
Compare
Tests added for:
psa_copy_keypsa_aead_encryptpsa_aead_decryptpsa_hash_computepsa_hash_comparepsa_raw_key_agreementSigned-off-by: Samuel Bailey samuel.bailey@arm.com