Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper methods for checking derivation policy flag #54

Merged

Conversation

sbailey-arm
Copy link
Contributor

Signed-off-by: Samuel Bailey samuel.bailey@arm.com

@sbailey-arm sbailey-arm marked this pull request as draft August 11, 2020 11:16
@sbailey-arm sbailey-arm force-pushed the add-vheck-derive-policy-helper branch from faa69e4 to 65cbf10 Compare August 11, 2020 11:17
@sbailey-arm sbailey-arm marked this pull request as ready for review August 11, 2020 12:38
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - unit tests? I'm always confused about whether we want tests for this kinda thing - code is trivial but maybe will be changed in the future?

Signed-off-by: Samuel Bailey <samuel.bailey@arm.com>
@sbailey-arm sbailey-arm force-pushed the add-vheck-derive-policy-helper branch from 65cbf10 to a992ceb Compare August 12, 2020 15:19
@sbailey-arm
Copy link
Contributor Author

Actually - unit tests? I'm always confused about whether we want tests for this kinda thing - code is trivial but maybe will be changed in the future?

Added a test for is_derivable, is that what you meant? Seem there are only tests for 3 other usage flags.

@ionut-arm ionut-arm merged commit 582f38b into parallaxsecond:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants