Implement Display on Algorithm #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
approved these changes
Feb 19, 2021
psa-crypto/src/types/key.rs
Outdated
| Type::Arc4 => write!(f, "Key for the RC4 stream cipher"), | ||
| Type::Chacha20 => write!( | ||
| f, | ||
| "Key for the ChaCha20 stream cipher or the Chacha20-Poly1305 AEAD algorithm" |
There was a problem hiding this comment.
Is this how it's defined in the spec? Seems sensible to just write it like the ones above Key for an algorithm based on ChaCha20
There was a problem hiding this comment.
Yees that's directly taken from the spec :/ https://parallaxsecond.github.io/parsec-book/parsec_client/operations/psa_key_attributes.html#chacha20-type
There was a problem hiding this comment.
Hmm, though you did "sanitize" the ones above, they're not just copy-pasted
Also fixes some clippy/deprecated errors. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
hug-dev
force-pushed
the
display-type
branch
from
091a86e to
6082719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes some clippy/deprecated errors.
Signed-off-by: Hugues de Valon hugues.devalon@arm.com