Skip to content

network: Change the STA visitConnectedPins API to UnorderedSet #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

network: Change the STA visitConnectedPins API to UnorderedSet #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/sta/ConcreteNetwork.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ protected:
void clearConstantNets();
void visitConnectedPins(const Net *net,
PinVisitor &visitor,
NetSet &visited_nets) const override;
UnorderedSet<const Net*> &visited_nets) const override;
Instance *makeConcreteInstance(ConcreteCell *cell,
const char *name,
Instance *parent);
Expand Down
3 changes: 2 additions & 1 deletion include/sta/Network.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "VertexId.hh"
#include "NetworkClass.hh"
#include "StaState.hh"
#include "UnorderedSet.hh"

namespace sta {

Expand Down Expand Up @@ -470,7 +471,7 @@ protected:
int hierarchyLevel(const Net *net) const;
virtual void visitConnectedPins(const Net *net,
PinVisitor &visitor,
NetSet &visited_nets) const;
UnorderedSet<const Net*> &visited_nets) const;
// Default implementation uses linear search.
virtual void findInstPinsMatching(const Instance *instance,
const PatternMatch *pattern,
Expand Down
2 changes: 1 addition & 1 deletion network/ConcreteNetwork.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,7 +1549,7 @@ ConcreteNetwork::constantPinIterator()
void
ConcreteNetwork::visitConnectedPins(const Net *net,
PinVisitor &visitor,
NetSet &visited_nets) const
UnorderedSet<const Net*> &visited_nets) const
{
if (!visited_nets.hasKey(net)) {
visited_nets.insert(net);
Expand Down
6 changes: 3 additions & 3 deletions network/Network.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,7 @@ void
Network::visitConnectedPins(const Pin *pin,
PinVisitor &visitor) const
{
NetSet visited_nets(network_);
UnorderedSet<const Net*> visited_nets;
Net *pin_net = net(pin);
Term *pin_term = term(pin);
if (pin_net)
Expand All @@ -1328,14 +1328,14 @@ void
Network::visitConnectedPins(const Net *net,
PinVisitor &visitor) const
{
NetSet visited_nets(this);
UnorderedSet<const Net*> visited_nets;
visitConnectedPins(net, visitor, visited_nets);
}

void
Network::visitConnectedPins(const Net *net,
PinVisitor &visitor,
NetSet &visited_nets) const
UnorderedSet<const Net*> &visited_nets) const
{
if (!visited_nets.hasKey(net)) {
visited_nets.insert(net);
Expand Down