-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to polkadot-v0.9.22 #1778
Bump to polkadot-v0.9.22 #1778
Conversation
|
||
[patch.crates-io] | ||
orml-traits = { git = 'https://github.com/open-web3-stack/open-runtime-module-library', rev = 'f709ed62262435b3ad80482d309e3575625d1e5b' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [detect-secrets] reported by reviewdog 🐶
- Hex High Entropy String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GopherJ could we relax check here? no 0.9.22 branch or tag in orml repo so just patch with matched rev commit here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but I didn't find how to configure reviewdog on this
sp-trie = { git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.22' } | ||
statemine-runtime = { git = 'https://github.com/paritytech/cumulus.git', branch = 'polkadot-v0.9.22' } | ||
statemint-runtime = { git = 'https://github.com/paritytech/cumulus.git', branch = 'polkadot-v0.9.22' } | ||
xcm-emulator = { git = 'https://github.com/shaunxw/xcm-simulator.git', rev = '5a04d6286ee9082d4b7433541e48508f8b65616b' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [detect-secrets] reported by reviewdog 🐶
- Hex High Entropy String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same,any way it is commit id not secret
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
==========================================
- Coverage 63.68% 63.67% -0.02%
==========================================
Files 158 158
Lines 15606 15610 +4
==========================================
Hits 9939 9939
- Misses 5667 5671 +4
Continue to review full report at Codecov.
|
relaychain with sudo&fast runtime customized in this branch(https://github.com/parallel-finance/polkadot/tree/release-v0.9.22-fast-sudo), should be built with |
ci for coverage breaks in https://github.com/parallel-finance/parallel/runs/6668255722?check_suite_focus=true
@GopherJ have you met this issue before, anything to do with github hosted runners? |
I haven't had this issue before, maybe coverage tool will need to be upgraded. |
upstream pr
paritytech/substrate#8783
paritytech/substrate#11241
paritytech/substrate#11198
checklist