Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to polkadot-v0.9.22 #1778

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Bump to polkadot-v0.9.22 #1778

merged 4 commits into from
Jun 1, 2022

Conversation

yrong
Copy link
Contributor

@yrong yrong commented May 30, 2022

upstream pr

paritytech/substrate#8783
paritytech/substrate#11241
paritytech/substrate#11198

checklist

  • bump to v0.9.22 & make code compile
  • introduce udeps & remove unused dependencies
  • fix breaking integration test
  • forked relaychain customization & launch config change & some live test

@yrong yrong requested a review from a team May 30, 2022 13:29

[patch.crates-io]
orml-traits = { git = 'https://github.com/open-web3-stack/open-runtime-module-library', rev = 'f709ed62262435b3ad80482d309e3575625d1e5b' }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [detect-secrets] reported by reviewdog 🐶

  • Hex High Entropy String

Copy link
Contributor Author

@yrong yrong May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GopherJ could we relax check here? no 0.9.22 branch or tag in orml repo so just patch with matched rev commit here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but I didn't find how to configure reviewdog on this

sp-trie = { git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.22' }
statemine-runtime = { git = 'https://github.com/paritytech/cumulus.git', branch = 'polkadot-v0.9.22' }
statemint-runtime = { git = 'https://github.com/paritytech/cumulus.git', branch = 'polkadot-v0.9.22' }
xcm-emulator = { git = 'https://github.com/shaunxw/xcm-simulator.git', rev = '5a04d6286ee9082d4b7433541e48508f8b65616b' }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [detect-secrets] reported by reviewdog 🐶

  • Hex High Entropy String

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same,any way it is commit id not secret

@codecov-commenter
Copy link

Codecov Report

Merging #1778 (23f717f) into master (e79ed0c) will decrease coverage by 0.01%.
The diff coverage is 3.57%.

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
- Coverage   63.68%   63.67%   -0.02%     
==========================================
  Files         158      158              
  Lines       15606    15610       +4     
==========================================
  Hits         9939     9939              
- Misses       5667     5671       +4     
Impacted Files Coverage Δ
node/parallel/src/client.rs 0.00% <ø> (ø)
node/parallel/src/rpc.rs 0.00% <0.00%> (ø)
node/parallel/src/service.rs 0.00% <0.00%> (ø)
pallets/currency-adapter/src/lib.rs 41.17% <0.00%> (ø)
pallets/loans/rpc/src/lib.rs 0.00% <0.00%> (ø)
pallets/loans/src/ptoken.rs 78.72% <ø> (ø)
pallets/router/rpc/src/lib.rs 0.00% <0.00%> (ø)
pallets/loans/src/tests/ptokens.rs 100.00% <100.00%> (ø)
runtime/heiko/src/weights/pallet_multisig.rs 0.00% <0.00%> (ø)
runtime/kerria/src/weights/pallet_multisig.rs 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79ed0c...23f717f. Read the comment docs.

@yrong
Copy link
Contributor Author

yrong commented May 31, 2022

relaychain with sudo&fast runtime customized in this branch(https://github.com/parallel-finance/polkadot/tree/release-v0.9.22-fast-sudo), should be built with
cargo build --release --features fast-runtime

@yrong
Copy link
Contributor Author

yrong commented May 31, 2022

ci for coverage breaks in https://github.com/parallel-finance/parallel/runs/6668255722?check_suite_focus=true
complain about compile failure but try in local setup execution succeed

cargo +nightly-2022-04-24 tarpaulin --verbose --no-fail-fast -p pallet-liquid-staking --timeout 300 --out Xml

@GopherJ have you met this issue before, anything to do with github hosted runners?

@GopherJ
Copy link
Contributor

GopherJ commented Jun 1, 2022

ci for coverage breaks in https://github.com/parallel-finance/parallel/runs/6668255722?check_suite_focus=true complain about compile failure but try in local setup execution succeed

cargo +nightly-2022-04-24 tarpaulin --verbose --no-fail-fast -p pallet-liquid-staking --timeout 300 --out Xml

@GopherJ have you met this issue before, anything to do with github hosted runners?

I haven't had this issue before, maybe coverage tool will need to be upgraded.

@GopherJ GopherJ merged commit abcca41 into master Jun 1, 2022
@GopherJ GopherJ deleted the polkadot-v0.9.22 branch June 1, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants